[PATCH] D36558: [llvm-objcopy] Add support for nested and overlapping segments

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 114913.
jakehehrlich added a comment.

Sorry about not getting that changed faster. That's just not ok. I apologize.

As for the FileSize < MemSize issue. The standard states "The file size may not be larger than the memory size" here: http://www.sco.com/developers/gabi/2012-12-31/ch5.pheader.html

I haven't seen anything producing any such binaries. Also LLD considers it a bug when it happens so that's at least one linker that promises to never do it. I think I'd rather throw an error on read in if this happens. Would that be ok?


Repository:
  rL LLVM

https://reviews.llvm.org/D36558

Files:
  test/tools/llvm-objcopy/adjacent-segments.test
  test/tools/llvm-objcopy/identical-segments.test
  test/tools/llvm-objcopy/overlap-chain.test
  test/tools/llvm-objcopy/pt-phdr.test
  test/tools/llvm-objcopy/triple-overlap.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36558.114913.patch
Type: text/x-patch
Size: 19306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170912/bc66d949/attachment.bin>