[PATCH] D36558: [llvm-objcopy] Add support for nested and overlapping segments

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

tripple-overlap.test still needs renaming!

I think it may be possible to have segments with zero MemSize but non-zero FileSize. I think it's unlikely to happen that they appear at offset zero, but I wouldn't want to guarantee it. As such, these should probably be considered in the algorithm as well, rather than being skipped. If they overlap another later segment, then the latter must stay relative to the former. We should have tests for these two cases as well, possibly independent of the completely empty segment.


Repository:
  rL LLVM

https://reviews.llvm.org/D36558