[PATCH] D37718: [ELF] Handle references to garbage collected common symbols

[Mikulin, Dmitry via llvm-commits]

> On Sep 12, 2017, at 1:35 PM, Rafael Avila de Espindola <rafael.espindola at gmail.com> wrote:
> 
> In DefinedRegular we check if OutputSection is null, which should be
> equivalent.
> 
> If we are going to have a section per common symbol, I think we can drop
> DefinedCommon. I will give that a try.

With the reported link time degradation we may need to re-visit section-per-common…
I’ll approve the fix in the Phabricator if no-one objects.

> 
> This LGTM to fix the crash.
> 
> Cheers,
> Rafael
> 
> Shoaib Meenai via Phabricator <reviews at reviews.llvm.org> writes:
> 
>> smeenai added a comment.
>> 
>> I'm seeing breakages caused by this as well. Thanks for the fix!
>> 
>> I'm also supportive of getting this patch in ASAP and looking into further improvements as a follow-up, since it fixes a linker crash.
>> 
>> 
>> https://reviews.llvm.org/D37718