[PATCH] D37718: [ELF] Handle references to garbage collected common symbols

[Rafael Avila de Espindola via llvm-commits]

In DefinedRegular we check if OutputSection is null, which should be
equivalent.

If we are going to have a section per common symbol, I think we can drop
DefinedCommon. I will give that a try.

This LGTM to fix the crash.

Cheers,
Rafael

Shoaib Meenai via Phabricator <reviews at reviews.llvm.org> writes:

> smeenai added a comment.
>
> I'm seeing breakages caused by this as well. Thanks for the fix!
>
> I'm also supportive of getting this patch in ASAP and looking into further improvements as a follow-up, since it fixes a linker crash.
>
>
> https://reviews.llvm.org/D37718