[lld] r312812 - Handle lazy symbols is computeIsPreemptible.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 10:20:19 PDT 2017


Sean Silva <chisophugis at gmail.com> writes:

>> --- lld/trunk/ELF/Writer.cpp (original)
>> +++ lld/trunk/ELF/Writer.cpp Fri Sep  8 11:41:49 2017
>> @@ -1240,7 +1240,7 @@ static bool computeIsPreemptible(const S
>>    // executables are automatically exported so that the runtime linker
>>    // can try to resolve them. In that case, they are preemptible. So, we
>>    // return true for an undefined symbols in all cases.
>> -  if (B.isUndefined() || B.isShared())
>> +  if (!B.isInCurrentDSO())
>>      return true;
>>
>
> The comment here probably needs some updating.

r313051, thanks.

Cheers,
Rafael


More information about the llvm-commits mailing list