[lld] r313051 - Update comment. NFC.

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 10:18:03 PDT 2017


Author: rafael
Date: Tue Sep 12 10:18:03 2017
New Revision: 313051

URL: http://llvm.org/viewvc/llvm-project?rev=313051&view=rev
Log:
Update comment. NFC.

Modified:
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=313051&r1=313050&r2=313051&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Tue Sep 12 10:18:03 2017
@@ -1224,12 +1224,8 @@ static bool computeIsPreemptible(const S
   if (B.symbol()->Visibility != STV_DEFAULT)
     return false;
 
-  // Undefined symbols in non-DSOs are usually just an error, so it
-  // doesn't matter whether we return true or false here. However, if
-  // -unresolved-symbols=ignore-all is specified, undefined symbols in
-  // executables are automatically exported so that the runtime linker
-  // can try to resolve them. In that case, they are preemptible. So, we
-  // return true for an undefined symbols in all cases.
+  // At this point copy relocations have not been created yet, so any
+  // symbol that is not defined locally is preemptible.
   if (!B.isInCurrentDSO())
     return true;
 




More information about the llvm-commits mailing list