[PATCH] D37683: [mips] Correcting operand range for DINSM instruction

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with inline nit addressed.



================
Comment at: test/MC/Mips/mips64r2/valid.s:109
         di                             # CHECK: di             # encoding: [0x41,0x60,0x60,0x00]
+        dinsm     $2,$3,4,32           # CHECK: dinsm $2, $3, 4, 32    # encoding: [0x7c,0x62,0x19,0x05]
         ddiv      $zero,$k0,$s3
----------------
This should be 34, as 32 is a valid operand for uimm5_inssize_plus1. 34 is not valid for uimm5_inssize_plus1 but is valid by the ISA description of the instruction.


================
Comment at: test/MC/Mips/mips64r6/valid.s:117
         di      $s8              # CHECK: di  $fp          # encoding: [0x41,0x7e,0x60,0x00]
+        dinsm   $2,$3,4,32       # CHECK: dinsm $2, $3, 4, 32 # encoding: [0x7c,0x62,0x19,0x05]
         div     $2,$3,$4         # CHECK: div $2, $3, $4   # encoding: [0x00,0x64,0x10,0x9a]
----------------
See my previous comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D37683