[PATCH] D36849: [AMDGPU] Port of HSAIL inliner
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 11 11:32:10 PDT 2017
rampitec added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUInline.cpp:176-177
+
+ if (isWrapperOnlyCall(CS))
+ return llvm::InlineCost::getAlways();
+
----------------
arsenm wrote:
> By doing this you could possibly be allowing inlining with incompatible function attributes. llvm:::getInlineCost has the additional functionsHaveCompatibleAttributes check, which is more than the above areInlineCompatible
areInlineCompatible() is called earlier at line 167. If they do not we will not get to this point.
https://reviews.llvm.org/D36849
More information about the llvm-commits
mailing list