[PATCH] D37421: [XRay] [test-suite] Add LNT support to retref-bench benchmarks.

[Hal Finkel via llvm-commits]

Hi, Eizan,

Thanks!

Matthias, thoughts?

  -Hal

On 09/10/2017 07:59 AM, Eizan Miyamoto wrote:
> hfiinkel@: I think I've done some of the things that you're 
> recommending, but I suspect that there is a bit more that you're 
> asking for.
>
> Issues with things as they are:
> - for each additional microbenchmark module (e.g., 'XRay', etc.), the 
> benchmark library will be rebuilt each time, which is probably suboptimal.
> - there is a lot of extra boilerplate required when adding another 
> module: you'd have to create another benchmark-1.2.0 symlink and 
> recreate most of the contents of MicroBenchmarks/XRay/CMakeLists.txt 
> in a new directory.
>
> Thoughts?
>
>
> On 10 September 2017 at 05:49, Eizan Miyamoto via Phabricator 
> <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
>
>     eizan updated this revision to Diff 114518.
>     eizan added a comment.
>
>     - move running of benchmark & parsing output into
>     lib/microbenchmark.py
>     - Move XRay dir into MicroBenchmarks and fix up paths
>     - move building of XRay benchmarks into microbenchmark lib
>     - pass ARCH to build_microbenchmark invocation of cmake
>
>
>     https://reviews.llvm.org/D37421 <https://reviews.llvm.org/D37421>
>
>     Files:
>       LNTBased/MicroBenchmarks/XRay/CMakeLists.txt
>       LNTBased/MicroBenchmarks/XRay/TestModule
>       LNTBased/MicroBenchmarks/XRay/XRay
>       LNTBased/MicroBenchmarks/XRay/benchmark-1.2.0
>       LNTBased/lib/microbenchmark.py
>
>

-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170910/23984d5c/attachment.html>