<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi, Eizan,</p>
<p>Thanks!</p>
<p>Matthias, thoughts?</p>
<p> -Hal<br>
</p>
<div class="moz-cite-prefix">On 09/10/2017 07:59 AM, Eizan Miyamoto
wrote:<br>
</div>
<blockquote
cite="mid:CAA3dwoFoMNSvBLk_NqoEHS0V7WDKJiyfwLLBDJVamMAzXs17eQ@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">hfiinkel@: I think I've done some of the things
that you're recommending, but I suspect that there is a bit more
that you're asking for.
<div><br>
</div>
<div>Issues with things as they are:</div>
<div>- for each additional microbenchmark module (e.g., 'XRay',
etc.), the benchmark library will be rebuilt each time, which
is probably suboptimal.</div>
<div>- there is a lot of extra boilerplate required when adding
another module: you'd have to create another benchmark-1.2.0
symlink and recreate most of the contents of
MicroBenchmarks/XRay/CMakeLists.txt in a new directory.</div>
<div><br>
</div>
<div>Thoughts?</div>
<div>
<div><br>
</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 10 September 2017 at 05:49, Eizan
Miyamoto via Phabricator <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">eizan
updated this revision to Diff 114518.<br>
eizan added a comment.<br>
<br>
- move running of benchmark & parsing output into
lib/microbenchmark.py<br>
- Move XRay dir into MicroBenchmarks and fix up paths<br>
- move building of XRay benchmarks into microbenchmark lib<br>
- pass ARCH to build_microbenchmark invocation of cmake<br>
<br>
<br>
<a moz-do-not-send="true"
href="https://reviews.llvm.org/D37421" rel="noreferrer"
target="_blank">https://reviews.llvm.org/<wbr>D37421</a><br>
<br>
Files:<br>
LNTBased/MicroBenchmarks/XRay/<wbr>CMakeLists.txt<br>
LNTBased/MicroBenchmarks/XRay/<wbr>TestModule<br>
LNTBased/MicroBenchmarks/XRay/<wbr>XRay<br>
LNTBased/MicroBenchmarks/XRay/<wbr>benchmark-1.2.0<br>
LNTBased/lib/microbenchmark.py<br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</body>
</html>