[PATCH] D36870: [libcxx] Add missing __cxa_deleted_virtual

Eric Fiselier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 10 16:45:15 PDT 2017


EricWF requested changes to this revision.
EricWF added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/abi/3.9/x86_64-apple-darwin16.abilist:2284
 {'type': 'U', 'name': '___cxa_bad_typeid'}
 {'type': 'I', 'name': '___cxa_begin_catch'}
 {'type': 'U', 'name': '___cxa_begin_catch'}
----------------
Files under `lib/abi/<version>` should not be changed. They're for already released versions of libc++, and this change doesn't affect those.


================
Comment at: lib/abi/x86_64-unknown-linux-gnu.abilist:1873
 {'is_defined': False, 'name': '__cxa_decrement_exception_refcount', 'type': 'FUNC'}
+{'is_defined': False, 'name': '__cxa_deleted_virtual', 'type': 'FUNC'}
 {'is_defined': False, 'name': '__cxa_end_catch', 'type': 'FUNC'}
----------------
Why are we changing the Linux lists when this change only affects OS X?


https://reviews.llvm.org/D36870





More information about the llvm-commits mailing list