[llvm] r312888 - Use llvm_unreachable for unknown TargetCostKind.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 10 11:42:23 PDT 2017


Author: rksimon
Date: Sun Sep 10 11:42:23 2017
New Revision: 312888

URL: http://llvm.org/viewvc/llvm-project?rev=312888&view=rev
Log:
Use llvm_unreachable for unknown TargetCostKind.

TargetTransformInfo::getInstructionCost's switch covers all TargetCostKind cases so we shouldn't return for a default case.

Modified:
    llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h

Modified: llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h?rev=312888&r1=312887&r2=312888&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h (original)
+++ llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h Sun Sep 10 11:42:23 2017
@@ -142,8 +142,7 @@ public:
     case TCK_CodeSize:
       return getUserCost(I);
     }
-
-    return 0;
+    llvm_unreachable("Unknown instruction cost kind");
   }
 
   /// \brief Underlying constants for 'cost' values in this interface.




More information about the llvm-commits mailing list