[PATCH] D37665: [SelectionDAG] Teach simplifyDemandedBits to handle shifts by constant splat vectors

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 9 13:06:41 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:784
+    if (ConstantSDNode *SA = isConstOrConstSplat(Op.getOperand(1))) {
+      unsigned ShAmt = SA->getLimitedValue(BitWidth);
       SDValue InOp = Op.getOperand(0);
----------------
Which do you think is better - getLimitedValue or using APInt::uge() which we do in other places?


https://reviews.llvm.org/D37665





More information about the llvm-commits mailing list