[PATCH] D37536: [compiler-rt] Move IsStackOverflow from asan into sanitizer_common

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka marked 2 inline comments as done.
vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix.cc:324
 
+//#if !SANITIZER_GO
+bool IsStackOverflow(int code, const SignalContext &sig) {
----------------
alekseyshl wrote:
> What about this #if?
#if allows to aviid sanitizer_platform_limits_posix.cc in lib/tsan/go/buildgo.sh



================
Comment at: compiler-rt/lib/tsan/go/buildgo.sh:48
 		../rtl/tsan_platform_linux.cc
+		../../sanitizer_common/sanitizer_platform_limits_posix.cc
 		../../sanitizer_common/sanitizer_posix.cc
----------------
alekseyshl wrote:
> What prompted it?
IsStackOverflow needs some constants from the file.
I don't like #ifs in the code, but maybe safer just to keep them instead of new file here.
What would be your preference here?


https://reviews.llvm.org/D37536