[PATCH] D37536: [compiler-rt] Move IsStackOverflow from asan into sanitizer_common
    Aleksey Shlyapnikov via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Sep  8 10:49:38 PDT 2017
    
    
  
alekseyshl added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix.cc:324
 
+//#if !SANITIZER_GO
+bool IsStackOverflow(int code, const SignalContext &sig) {
----------------
What about this #if?
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cc:218
 }
+
 #endif  // SANITIZER_GO
----------------
Looks like an unnecessary change
================
Comment at: compiler-rt/lib/tsan/go/buildgo.sh:48
 		../rtl/tsan_platform_linux.cc
+		../../sanitizer_common/sanitizer_platform_limits_posix.cc
 		../../sanitizer_common/sanitizer_posix.cc
----------------
What prompted it?
https://reviews.llvm.org/D37536
    
    
More information about the llvm-commits
mailing list