[PATCH] D33650: MachineVerifier: Verify liveins list

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D33650#864758, @jonpa wrote:

> > Make sure that at the end of basic blocks the liveins of the successor blocks are live (or the CSRs in case of return blocks)
>
> So this only checks that there are not any false live-in entries in the live-in lists of successors, meaning that there could still be missing regs in the live-in lists of successors?


Missing regs will already be catched (use of an undefined register). The important check here is that regs marked live-in are actually alive at the end of the predecessor blocks.

> I remember a discussion a while back ago to switch to reg-units instead for live-in lists - what is the status on it?

No active work on it.

> How about using the RDF patch instead of this? I am thinking that since it actually computes the live-ins, it can easily verify the live-in lists. This would also be a way to get RDF into outside Hexagon.

It's a good idea to write separate code for the verifier so bugs don't cancel each other out (it's also deliberately not using LiveIntervals here).


Repository:
  rL LLVM

https://reviews.llvm.org/D33650