[PATCH] D33650: MachineVerifier: Verify liveins list

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 8 07:21:16 PDT 2017


jonpa added a comment.

> Make sure that at the end of basic blocks the liveins of the successor blocks are live (or the CSRs in case of return blocks)

So this only checks that there are not any false live-in entries in the live-in lists of successors, meaning that there could still be missing regs in the live-in lists of successors?

I remember a discussion a while back ago to switch to reg-units instead for live-in lists - what is the status on it?

How about using the RDF patch instead of this? I am thinking that since it actually computes the live-ins, it can easily verify the live-in lists. This would also be a way to get RDF into outside Hexagon.


Repository:
  rL LLVM

https://reviews.llvm.org/D33650





More information about the llvm-commits mailing list