[PATCH] D31139: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed with EHABI

[Christian Bruel via Phabricator via llvm-commits]

chrib added a comment.



In https://reviews.llvm.org/D31139#863908, @efriedma wrote:

> I'm sort of concerned this introduces a subtle hole in the semantics of IR auto-upgrade... but I guess it's unlikely to matter.
>
> Some bits of the patch have weird indentation; please clang-format C++ code.


ah yes. thanks.

> Should we be using Function::needsUnwindTableEntry() rather than Function::hasUWTable()?

I'm not sure. needsUnwindTableEntry checks !doesNotThrow  in addition to hasUWTable so this is redundant here. The logic for arm is really to emit unwind annotation if the attribute is there, even if the function cantunwind (e.g doesNotThrow),


https://reviews.llvm.org/D31139