[PATCH] D31139: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed with EHABI

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 13:24:23 PDT 2017


efriedma added a comment.

I'm sort of concerned this introduces a subtle hole in the semantics of IR auto-upgrade... but I guess it's unlikely to matter.

Some bits of the patch have weird indentation; please clang-format C++ code.

Should we be using Function::needsUnwindTableEntry() rather than Function::hasUWTable()?


https://reviews.llvm.org/D31139





More information about the llvm-commits mailing list