[lld] r312762 - COFF: Remove unnecessary casts. NFCI.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 16:49:09 PDT 2017


Author: pcc
Date: Thu Sep  7 16:49:09 2017
New Revision: 312762

URL: http://llvm.org/viewvc/llvm-project?rev=312762&view=rev
Log:
COFF: Remove unnecessary casts. NFCI.

Modified:
    lld/trunk/COFF/Driver.cpp

Modified: lld/trunk/COFF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Driver.cpp?rev=312762&r1=312761&r2=312762&view=diff
==============================================================================
--- lld/trunk/COFF/Driver.cpp (original)
+++ lld/trunk/COFF/Driver.cpp Thu Sep  7 16:49:09 2017
@@ -840,7 +840,7 @@ void LinkerDriver::link(ArrayRef<const c
         Config->DoICF = false;
         continue;
       }
-      if (S == "icf" || StringRef(S).startswith("icf=")) {
+      if (S == "icf" || S.startswith("icf=")) {
         Config->DoICF = true;
         continue;
       }
@@ -848,21 +848,21 @@ void LinkerDriver::link(ArrayRef<const c
         Config->DoICF = false;
         continue;
       }
-      if (StringRef(S).startswith("lldlto=")) {
-        StringRef OptLevel = StringRef(S).substr(7);
+      if (S.startswith("lldlto=")) {
+        StringRef OptLevel = S.substr(7);
         if (OptLevel.getAsInteger(10, Config->LTOOptLevel) ||
             Config->LTOOptLevel > 3)
           error("/opt:lldlto: invalid optimization level: " + OptLevel);
         continue;
       }
-      if (StringRef(S).startswith("lldltojobs=")) {
-        StringRef Jobs = StringRef(S).substr(11);
+      if (S.startswith("lldltojobs=")) {
+        StringRef Jobs = S.substr(11);
         if (Jobs.getAsInteger(10, Config->LTOJobs) || Config->LTOJobs == 0)
           error("/opt:lldltojobs: invalid job count: " + Jobs);
         continue;
       }
-      if (StringRef(S).startswith("lldltopartitions=")) {
-        StringRef N = StringRef(S).substr(17);
+      if (S.startswith("lldltopartitions=")) {
+        StringRef N = S.substr(17);
         if (N.getAsInteger(10, Config->LTOPartitions) ||
             Config->LTOPartitions == 0)
           error("/opt:lldltopartitions: invalid partition count: " + N);




More information about the llvm-commits mailing list