[llvm] r312761 - Don't call exit from cl::PrintHelpMessage.
Rafael Espindola via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 7 16:30:48 PDT 2017
Author: rafael
Date: Thu Sep 7 16:30:48 2017
New Revision: 312761
URL: http://llvm.org/viewvc/llvm-project?rev=312761&view=rev
Log:
Don't call exit from cl::PrintHelpMessage.
Most callers were not expecting the exit(0) and trying to exit with a
different value.
This also adds back the call to cl::PrintHelpMessage in llvm-ar.
Modified:
llvm/trunk/include/llvm/Support/CommandLine.h
llvm/trunk/lib/Support/CommandLine.cpp
llvm/trunk/test/tools/llvm-ar/invalid-command-line.test
llvm/trunk/tools/dsymutil/dsymutil.cpp
llvm/trunk/tools/llvm-ar/llvm-ar.cpp
llvm/trunk/tools/llvm-opt-report/OptReport.cpp
llvm/trunk/tools/llvm-xray/llvm-xray.cc
Modified: llvm/trunk/include/llvm/Support/CommandLine.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/CommandLine.h?rev=312761&r1=312760&r2=312761&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/CommandLine.h (original)
+++ llvm/trunk/include/llvm/Support/CommandLine.h Thu Sep 7 16:30:48 2017
@@ -1762,8 +1762,6 @@ void PrintVersionMessage();
/// This function just prints the help message, exactly the same way as if the
/// -help or -help-hidden option had been given on the command line.
///
-/// NOTE: THIS FUNCTION TERMINATES THE PROGRAM!
-///
/// \param Hidden if true will print hidden options
/// \param Categorized if true print options in categories
void PrintHelpMessage(bool Hidden = false, bool Categorized = false);
Modified: llvm/trunk/lib/Support/CommandLine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/CommandLine.cpp?rev=312761&r1=312760&r2=312761&view=diff
==============================================================================
--- llvm/trunk/lib/Support/CommandLine.cpp (original)
+++ llvm/trunk/lib/Support/CommandLine.cpp Thu Sep 7 16:30:48 2017
@@ -1758,7 +1758,13 @@ public:
void operator=(bool Value) {
if (!Value)
return;
+ printHelp();
+ // Halt the program since help information was printed
+ exit(0);
+ }
+
+ void printHelp() {
SubCommand *Sub = GlobalParser->getActiveSubCommand();
auto &OptionsMap = Sub->OptionsMap;
auto &PositionalOpts = Sub->PositionalOpts;
@@ -1826,9 +1832,6 @@ public:
for (auto I : GlobalParser->MoreHelp)
outs() << I;
GlobalParser->MoreHelp.clear();
-
- // Halt the program since help information was printed
- exit(0);
}
};
@@ -2098,21 +2101,14 @@ static cl::opt<VersionPrinter, true, par
// Utility function for printing the help message.
void cl::PrintHelpMessage(bool Hidden, bool Categorized) {
- // This looks weird, but it actually prints the help message. The Printers are
- // types of HelpPrinter and the help gets printed when its operator= is
- // invoked. That's because the "normal" usages of the help printer is to be
- // assigned true/false depending on whether -help or -help-hidden was given or
- // not. Since we're circumventing that we have to make it look like -help or
- // -help-hidden were given, so we assign true.
-
if (!Hidden && !Categorized)
- UncategorizedNormalPrinter = true;
+ UncategorizedNormalPrinter.printHelp();
else if (!Hidden && Categorized)
- CategorizedNormalPrinter = true;
+ CategorizedNormalPrinter.printHelp();
else if (Hidden && !Categorized)
- UncategorizedHiddenPrinter = true;
+ UncategorizedHiddenPrinter.printHelp();
else
- CategorizedHiddenPrinter = true;
+ CategorizedHiddenPrinter.printHelp();
}
/// Utility function for printing version number.
Modified: llvm/trunk/test/tools/llvm-ar/invalid-command-line.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-ar/invalid-command-line.test?rev=312761&r1=312760&r2=312761&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-ar/invalid-command-line.test (original)
+++ llvm/trunk/test/tools/llvm-ar/invalid-command-line.test Thu Sep 7 16:30:48 2017
@@ -2,3 +2,4 @@ Test that llvm-ar exits with 1 when ther
RUN: not llvm-ar e 2>&1 | FileCheck %s
CHECK: unknown option e.
+CHECK: OVERVIEW: LLVM Archiver (llvm-ar)
Modified: llvm/trunk/tools/dsymutil/dsymutil.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/dsymutil.cpp?rev=312761&r1=312760&r2=312761&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/dsymutil.cpp (original)
+++ llvm/trunk/tools/dsymutil/dsymutil.cpp Thu Sep 7 16:30:48 2017
@@ -253,8 +253,10 @@ int main(int argc, char **argv) {
"for the executable <input file> by using debug symbols information\n"
"contained in its symbol table.\n");
- if (Help)
+ if (Help) {
PrintHelpMessage();
+ return 0;
+ }
if (Version) {
llvm::cl::PrintVersionMessage();
Modified: llvm/trunk/tools/llvm-ar/llvm-ar.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/llvm-ar.cpp?rev=312761&r1=312760&r2=312761&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-ar/llvm-ar.cpp (original)
+++ llvm/trunk/tools/llvm-ar/llvm-ar.cpp Thu Sep 7 16:30:48 2017
@@ -54,8 +54,7 @@ static StringRef ToolName;
// Show the error message and exit.
LLVM_ATTRIBUTE_NORETURN static void fail(Twine Error) {
errs() << ToolName << ": " << Error << ".\n";
- // FIXME: Other ar implementations will print the command line help in here.
- // Unfortunately cl::PrintHelpMessage() exits with 0, so we can't call it.
+ cl::PrintHelpMessage();
exit(1);
}
Modified: llvm/trunk/tools/llvm-opt-report/OptReport.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-opt-report/OptReport.cpp?rev=312761&r1=312760&r2=312761&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-opt-report/OptReport.cpp (original)
+++ llvm/trunk/tools/llvm-opt-report/OptReport.cpp Thu Sep 7 16:30:48 2017
@@ -514,8 +514,10 @@ int main(int argc, const char **argv) {
"A tool to generate an optimization report from YAML optimization"
" record files.\n");
- if (Help)
+ if (Help) {
cl::PrintHelpMessage();
+ return 0;
+ }
LocationInfoTy LocationInfo;
if (!readLocationInfo(LocationInfo))
Modified: llvm/trunk/tools/llvm-xray/llvm-xray.cc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-xray/llvm-xray.cc?rev=312761&r1=312760&r2=312761&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-xray/llvm-xray.cc (original)
+++ llvm/trunk/tools/llvm-xray/llvm-xray.cc Thu Sep 7 16:30:48 2017
@@ -46,4 +46,5 @@ int main(int argc, char *argv[]) {
// If all else fails, we still print the usage message.
cl::PrintHelpMessage(false, true);
+ return 0;
}
More information about the llvm-commits
mailing list