[PATCH] D36579: [ELF] - Do not fail when set versions for linkerscript's symbol aliases

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:1021
 
+  // Add symbols defined in linker scripts early because otherwise version
+  // scripts referring script-synthesized symbols wouldn't work due to
----------------
Add symbols -> Add dummy symbols


================
Comment at: ELF/Driver.cpp:1027
+    if (SymbolAssignment *Cmd = dyn_cast<SymbolAssignment>(Base))
+      if (Cmd->Name != "." && !Symtab->find(Cmd->Name) && !Cmd->Provide)
+        Symtab->addAbsolute<ELFT>(Cmd->Name, STV_DEFAULT, STB_WEAK);
----------------
What is `!Cmd->Provide` for?


================
Comment at: ELF/Driver.cpp:1028
+      if (Cmd->Name != "." && !Symtab->find(Cmd->Name) && !Cmd->Provide)
+        Symtab->addAbsolute<ELFT>(Cmd->Name, STV_DEFAULT, STB_WEAK);
+
----------------
Is there any reason to create symbols as STB_WEAK?


https://reviews.llvm.org/D36579