[PATCH] D36579: [ELF] - Do not fail when set versions for linkerscript's symbol aliases

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Driver.cpp:978
+template <class ELFT>
+static void addScriptSymbols() {
+  // Some symbols (such as __ehdr_start) are defined lazily only when there
----------------
ruiu wrote:
> Inline this function.
Done.


================
Comment at: ELF/Driver.cpp:984
+
+  // Add symbols defined in linkerscript.
+  for (BaseCommand *Base : Script->Opt.Commands)
----------------
ruiu wrote:
> Add symbols defined in linker scripts early because otherwise version
> scripts referring script-synthesized symbols wouldn't work due to undefined
> symbol error. (Version scripts are processed earlier than linker scripts.)
Added, thanks for comment !


https://reviews.llvm.org/D36579