[PATCH] D29934: [RISCV 12/n] Codegen support for memory operations
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 7 04:02:41 PDT 2017
asb added inline comments.
================
Comment at: lib/Target/RISCV/RISCVMCInstLower.cpp:53
+ ME = MCBinaryExpr::createAdd(
+ ME, MCConstantExpr::create(MO.getOffset(), Ctx), Ctx);
+
----------------
mgrang wrote:
> Not sure about the indentation of this line. Can you run clang-format?
This line was produced by clang-format.
================
Comment at: lib/Target/RISCV/RISCVMCInstLower.cpp:77
+ MCOp = MCOperand::createExpr(
+ MCSymbolRefExpr::create(MO.getMBB()->getSymbol(), AP.OutContext));
+ break;
----------------
mgrang wrote:
> Same here.
This line was also produced by clang-format, however I notice indentation of this whole function was was broken during some refactoring. Fixed.
https://reviews.llvm.org/D29934
More information about the llvm-commits
mailing list