[PATCH] D29934: [RISCV 12/n] Codegen support for memory operations

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/Target/RISCV/RISCVMCInstLower.cpp:53
+    ME = MCBinaryExpr::createAdd(
+        ME, MCConstantExpr::create(MO.getOffset(), Ctx), Ctx);
+
----------------
Not sure about the indentation of this line. Can you run clang-format?


================
Comment at: lib/Target/RISCV/RISCVMCInstLower.cpp:77
+      MCOp = MCOperand::createExpr(
+          MCSymbolRefExpr::create(MO.getMBB()->getSymbol(), AP.OutContext));
+      break;
----------------
Same here.


https://reviews.llvm.org/D29934