[PATCH] D37477: [ELF] - Linkerscript: implement REGION_ALIAS.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/ScriptParser.cpp:1240-1242
+    MemoryRegion *MR = make<MemoryRegion>();
+    *MR = {Name, Origin, Length, Flags, NegFlags};
+    Script->Opt.MemoryRegions[Name] = MR;
----------------
ruiu wrote:
> grimar wrote:
> > ruiu wrote:
> > > Does this work?
> > > 
> > >   Script->Opt.MemoryRegions[Name] =
> > >     make<MemoryRegion>(Name, Origin, Length, Flags, NegFlags);
> > Nope. Error is: "'lld::elf::MemoryRegion::MemoryRegion': no overloaded function takes 5 arguments",
> > that is why I did not do that initially. I believe it will work if we add constructor taking these 5 to
> > `MemoryRegion`, but does not seems it really worth to do for me.
> Then how about this?
> 
>    Script->Opt.MemoryRegions[Name] =
>      make<MemoryRegion>({Name, Origin, Length, Flags, NegFlags});
That was first I tried initially, it will error out:
error C2660: 'lld::elf::make': function does not take 1 arguments

As I mentioned, with constructor taking this arguments it is possible to use
```
    Script->Opt.MemoryRegions[Name] =
      make<MemoryRegion>(Name, Origin, Length, Flags, NegFlags);
```

Do you want me to add constructor ?


https://reviews.llvm.org/D37477