[PATCH] D37477: [ELF] - Linkerscript: implement REGION_ALIAS.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 6 11:19:06 PDT 2017
ruiu added inline comments.
================
Comment at: ELF/ScriptParser.cpp:1240-1242
+ MemoryRegion *MR = make<MemoryRegion>();
+ *MR = {Name, Origin, Length, Flags, NegFlags};
+ Script->Opt.MemoryRegions[Name] = MR;
----------------
grimar wrote:
> ruiu wrote:
> > Does this work?
> >
> > Script->Opt.MemoryRegions[Name] =
> > make<MemoryRegion>(Name, Origin, Length, Flags, NegFlags);
> Nope. Error is: "'lld::elf::MemoryRegion::MemoryRegion': no overloaded function takes 5 arguments",
> that is why I did not do that initially. I believe it will work if we add constructor taking these 5 to
> `MemoryRegion`, but does not seems it really worth to do for me.
Then how about this?
Script->Opt.MemoryRegions[Name] =
make<MemoryRegion>({Name, Origin, Length, Flags, NegFlags});
https://reviews.llvm.org/D37477
More information about the llvm-commits
mailing list