[PATCH] D34543: Track globals promoted to coalesced const pool entries

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

Sure, I can commit it on your behalf.



================
Comment at: test/CodeGen/ARM/constantpool-promote-duplicate.ll:3-4
+
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "thumbv7m--linux-gnu"
+
----------------
rinon wrote:
> compnerd wrote:
> > I think that you can drop these.  I dont think that there is anything Linux specific about this.  I think that `thumbv7-unknown-none-eabi` is a better target.
> I used arm-eabi since it seems to be used in other ARM tests and this test doesn't depend on any thumb behavior. Is that alright?
The other tests using it isn't the best argument.  However, armv7-eabi is as good as thumbv7-eabi in this case.


https://reviews.llvm.org/D34543