[PATCH] D34543: Track globals promoted to coalesced const pool entries

[Stephen Crane via Phabricator via llvm-commits]

rinon marked 3 inline comments as done.
rinon added a comment.

Thanks, addressed test changes. Can someone commit this patch?



================
Comment at: test/CodeGen/ARM/constantpool-promote-duplicate.ll:3-4
+
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+target triple = "thumbv7m--linux-gnu"
+
----------------
compnerd wrote:
> I think that you can drop these.  I dont think that there is anything Linux specific about this.  I think that `thumbv7-unknown-none-eabi` is a better target.
I used arm-eabi since it seems to be used in other ARM tests and this test doesn't depend on any thumb behavior. Is that alright?


https://reviews.llvm.org/D34543