[PATCH] D37240: Fix crbug 759265 by suppressing llvm mt warnings.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

> The reason why the "createManifestWithTool" functions are conditionally defined is not to avoid a compiler error, rather a compiler warning is given saying that the function is defined but never used.

I think this is a reason I'd completely avoid C macros in lld as a WindowsManifestMerger user.

If your WindowsManifestMerger is designed to provide an empty implementation when libxml2 is not available, then the aim of doing it should be to avoid C macros on the user side of the class. Currently, it is a mix of the two, so it doesn't eliminate a use of C macros on the user side but also provides an empty implementation (which is redundant if everything is conditionally-compiled). Since you took one approach (which is to provide an empty implementation), I think you want to make it usable without C macros.

If you define `WindowsManifestMerger::isAvailable()` function or something that returns true if libxml2 is available, you won't get a compiler warning.


https://reviews.llvm.org/D37240