[PATCH] D37240: Fix crbug 759265 by suppressing llvm mt warnings.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added a comment.

In https://reviews.llvm.org/D37240#861561, @ruiu wrote:

> Hmm, now it doesn't look like it is towards a right direction.
>
> As I understand the API of your WindowsManifestMerger class, it provides an empty implementation if libxml2 is not available so any code that uses your WindowsManifestMerger class can compile at least on any condition (though it may raise an error/returns an empty result at runtime if it wasn't compiled with libxml2). This patch uses conditional compilation to avoid compiler errors, which seems a violation of the rule.


The reason why the "createManifestWithTool" functions are conditionally defined is not to avoid a compiler error, rather a compiler warning is given saying that the function is defined but never used.


https://reviews.llvm.org/D37240