[PATCH] D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: include/llvm/Target/TargetSelectionDAG.td:685
+
+  // Should the data type of the immediate be an APInt?
+  bit IsAPInt = 0;
----------------
javed.absar wrote:
> I am no expert on this, but would the comment be better as 'Is the data type... "
> The 'Should the data... " seems to suggest an uncertainty (not sure), which is not the case here.
Both make sense to me since in both cases tablegen is asking the question of the user and the user supplies the answer in the field. If there's a preference for a particular phrasing then I'm happy to change it.


https://reviews.llvm.org/D36534