[PATCH] D36534: [aarch64] Support APInt and APFloat in ImmLeaf subclasses and make AArch64 use them.
Javed Absar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 4 11:47:10 PDT 2017
javed.absar added inline comments.
================
Comment at: include/llvm/Target/TargetSelectionDAG.td:685
+
+ // Should the data type of the immediate be an APInt?
+ bit IsAPInt = 0;
----------------
I am no expert on this, but would the comment be better as 'Is the data type... "
The 'Should the data... " seems to suggest an uncertainty (not sure), which is not the case here.
https://reviews.llvm.org/D36534
More information about the llvm-commits
mailing list