[PATCH] D35802: XFAIL tests on SLES11

Marshall Clow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 09:43:00 PDT 2017


mclow.lists added inline comments.


================
Comment at: utils/libcxx/test/target_info.py:193
         name, _, _ = platform.linux_distribution()
-        name = name.lower().strip()
         return name # Permitted to be None
----------------
bcain wrote:
> mclow.lists wrote:
> > A comment here would be helpful to future readers.
> How about "# some distros have spaces, lit doesn't cope well with those so we'll replace w/dashes" ?
Yes. something like that. (with the SUSE example, maybe)


Repository:
  rL LLVM

https://reviews.llvm.org/D35802





More information about the llvm-commits mailing list