[PATCH] D35802: XFAIL tests on SLES11
Brian Cain via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 31 08:54:16 PDT 2017
bcain added a comment.
In https://reviews.llvm.org/D35802#857702, @mclow.lists wrote:
> Can you give an example of linux distro names with spaces in it?
> Other than that, this looks fine to me.
platform.linux_distribution()[0] gives "SUSE Linux Enterprise Server" on SLES11.
================
Comment at: utils/libcxx/test/target_info.py:193
name, _, _ = platform.linux_distribution()
- name = name.lower().strip()
return name # Permitted to be None
----------------
mclow.lists wrote:
> A comment here would be helpful to future readers.
How about "# some distros have spaces, lit doesn't cope well with those so we'll replace w/dashes" ?
Repository:
rL LLVM
https://reviews.llvm.org/D35802
More information about the llvm-commits
mailing list