[PATCH] D37055: [ARM] Reverse PostRASched subtarget feature logic

[Javed Absar via Phabricator via llvm-commits]

javed.absar added inline comments.


================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:364
     return false;
-  return (!isThumb() || hasThumb2());
+  return !isThumb1Only();
 }
----------------
samparker wrote:
> javed.absar wrote:
> > may be add an explicit comment on why we choose to do this
> 'Because the gods of old said so.' Honestly, I'm really not sure of the reason and the logic seems odd to me. Unfortunately a lot of tests rely on this behaviour and its not something that I want to look into at the moment.
I think it is because of IT block - we don't want PostRA to mess it up.


https://reviews.llvm.org/D37055