[PATCH] D37055: [ARM] Reverse PostRASched subtarget feature logic

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 07:16:30 PDT 2017


samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:364
     return false;
-  return (!isThumb() || hasThumb2());
+  return !isThumb1Only();
 }
----------------
javed.absar wrote:
> may be add an explicit comment on why we choose to do this
'Because the gods of old said so.' Honestly, I'm really not sure of the reason and the logic seems odd to me. Unfortunately a lot of tests rely on this behaviour and its not something that I want to look into at the moment.


https://reviews.llvm.org/D37055





More information about the llvm-commits mailing list