[PATCH] D36862: AMDGPU: Handle non-temporal loads and stores

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:71
+          FailureOrdering(FailureOrdering) {
+      assert(Ordering != AtomicOrdering::NotAtomic);
+    }
----------------
Since there are now separate constructors for each usage case this one seems to only be used for CAS and so should this also enforce:

```
assert(FailureOrdering != AtomicOrdering::NotAtomic);
```


================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:262-264
+    return MemOpInfo(SyncScope::System,
+                     AtomicOrdering::SequentiallyConsistent,
+                     AtomicOrdering::NotAtomic);
----------------
Should this be using the new 2 argument constructor?


https://reviews.llvm.org/D36862