[PATCH] D36862: AMDGPU: Handle non-temporal loads and stores

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 11:30:08 PDT 2017


kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:254-255
     return None;
   if (!MI->hasOneMemOperand())
     return MemOpInfo();
 
----------------
t-tye wrote:
> What are examples of instructions that have multiple memory operands? Is is valid to treat them as system scope sequentially consistent atomic and !nontemporarl? Would it be clearer to call the constructor with the arguments explicit so can see what this is actually returning?
> 
> Same comment for other places doing this.
I don't know of any.


https://reviews.llvm.org/D36862





More information about the llvm-commits mailing list