[PATCH] D37222: AMDGPU: Start selecting v_mad_mix_f32

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1671
+
+  assert(!Subtarget->hasFP32Denormals() &&
+         "fmad selected with denormals enabled");
----------------
rampitec wrote:
> arsenm wrote:
> > arsenm wrote:
> > > rampitec wrote:
> > > > What practical sense does it have, if we default to support f32 denorms on GFX9 and have no such instructions before?
> > > Graphics still disables f32 denormals
> > Also the TODO is for the case where we can use this with denormals enabled.
> OK. What prevents FMAD from being selected if denorms are supported?
We should also probably bring back the less-precise-fpmad option. That would also probably make this valid to use


https://reviews.llvm.org/D37222