[PATCH] D37222: AMDGPU: Start selecting v_mad_mix_f32

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 17:27:09 PDT 2017


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1671
+
+  assert(!Subtarget->hasFP32Denormals() &&
+         "fmad selected with denormals enabled");
----------------
arsenm wrote:
> arsenm wrote:
> > rampitec wrote:
> > > What practical sense does it have, if we default to support f32 denorms on GFX9 and have no such instructions before?
> > Graphics still disables f32 denormals
> Also the TODO is for the case where we can use this with denormals enabled.
OK. What prevents FMAD from being selected if denorms are supported?


https://reviews.llvm.org/D37222





More information about the llvm-commits mailing list