[PATCH] D37184: [X86] Add constant pool decoding to more instructions

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: lib/Target/X86/X86MCInstLower.cpp:1396-1405
+  for (unsigned i = 0; i < Vec.size(); ++i) {
+    if (i != 0)
+      CS << ",";
+    if (UndefElts[i])
+      CS << 'u';
+    else
+      CS << Vec[i];
----------------
Can you detect a splat here and print something like "[0x1234 splat]"? That would greatly improve readability in the common case IMO, and make it clear in the odd case when the constant is not a splat.


https://reviews.llvm.org/D37184