[PATCH] D37184: [X86] Add constant pool decoding to more instructions
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 26 16:08:51 PDT 2017
chandlerc added a comment.
Generally speaking, I love this kind of thing. I think it makes tests and the actual assembly dramatically easier to read.
Some comments:
1. I think we should just print hex everywhere, always. I keep trying to think of why we *shouldn't* print in hex, and I've got nothing...
2. I don't feel strongly about byte vs. other granualarity for AND/OR/XOR... Maybe byte-digit-separated single integer? So, `0xFF'FF'FF'FF'FF'FF...`. Dunno, don't feel strongly about any of this
3. We should probably change the movdqa and such printing to use the same code for formatting the integers?
https://reviews.llvm.org/D37184
More information about the llvm-commits
mailing list