[PATCH] D37139: [x86] Extend the manual ISel of `add` and `sub` with both RMW memory operands and used flags to support matching immediate operands.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 17:35:28 PDT 2017


chandlerc updated this revision to Diff 112766.
chandlerc added a comment.

Update with minor formatting fixes and a major fix to correctly detect usage of
CF from an operation and suppress toggling between ADD and SUB in that case.

We could in theory *invert* the usage in the case of conditional branches and
such but it doesn't seem worth it.


https://reviews.llvm.org/D37139

Files:
  lib/Target/X86/X86ISelDAGToDAG.cpp
  test/CodeGen/X86/add.ll
  test/CodeGen/X86/fold-rmw-ops.ll
  test/CodeGen/X86/peephole-na-phys-copy-folding.ll
  test/CodeGen/X86/pr32659.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37139.112766.patch
Type: text/x-patch
Size: 47711 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170826/41b6e48f/attachment.bin>


More information about the llvm-commits mailing list