[PATCH] D37139: [x86] Extend the manual ISel of `add` and `sub` with both RMW memory operands and used flags to support matching immediate operands.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2068
+  auto SelectOpcode = [&](unsigned Opc64, unsigned Opc32, unsigned Opc16,
+                                 unsigned Opc8 = 0) {
     switch (MemVT.getSimpleVT().SimpleTy) {
----------------
Why did the fourth parameter get indented funny?


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2144
+      // operation.
+      if ((MemVT != MVT::i8 && OperandV.getMinSignedBits() > 8 &&
+           (-OperandV).getMinSignedBits() <= 8) ||
----------------
This isn't safe if the flag user wants the C flag is it?


https://reviews.llvm.org/D37139