[PATCH] D37151: [AArch64] Adjust the cost model for Exynos M1 and M2
Evandro Menezes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 25 12:14:21 PDT 2017
evandro added a comment.
In https://reviews.llvm.org/D37151#852690, @MatzeB wrote:
> - I'd leave out the `if (Subtarget.getProcFamily() != AArch64Subtarget::ExynosM1) return false;` check in `isExynosShiftExtFast()` if someone chose the Exynos scheduling he probably wants that behavior even if `getProcFamily()` doesn't match. (You can pull the check out to `isAsCheapAsAMove()`).
OK
> - This must have happened in an earlier commit already, but in any case I'd really discourage the use of `Subtarget.getProcFamily()`, better create a subtarget feature to control the behavior.
It's legacy code before the refactoring of such calls that I didn't feel this to be the time to address.
Repository:
rL LLVM
https://reviews.llvm.org/D37151
More information about the llvm-commits
mailing list