[PATCH] D37151: [AArch64] Adjust the cost model for Exynos M1 and M2

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 10:14:47 PDT 2017


MatzeB added a comment.

- I'd leave out the `if (Subtarget.getProcFamily() != AArch64Subtarget::ExynosM1) return false;` check in `isExynosShiftExtFast()` if someone chose the Exynos scheduling he probably wants that behavior even if `getProcFamily()` doesn't match. (You can pull the check out to `isAsCheapAsAMove()`).
- This must have happened in an earlier commit already, but in any case I'd really discourage the use of `Subtarget.getProcFamily()`, better create a subtarget feature to control the behavior.


Repository:
  rL LLVM

https://reviews.llvm.org/D37151





More information about the llvm-commits mailing list