[PATCH] D37111: [llvm-cov] Read in function names for filtering from a text file.

[Sean Eveson via Phabricator via llvm-commits]

seaneveson marked an inline comment as done.
seaneveson added inline comments.


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:656
+    // Read in -name-whitelist files.
+    for (const auto &NameFile : NameFilterFiles) {
+      auto BufOrError = MemoryBuffer::getFile(NameFile);
----------------
vsk wrote:
> In the future, we might benefit from the flexibility offered by llvm::SpecialCaseList. Could you use that to parse the whitelist?
Thanks for the review!

Having to specify a section for each item seems redundant for an option that only filters on function names, e.g.

```
fun:foo
fun:bar
```

Are you considering having a more general `-whitelist` rather than a `-name-whitelist`? Otherwise I'm not sure what other sections there would be. The wildcard handling would be useful though.


https://reviews.llvm.org/D37111