[PATCH] D37111: [llvm-cov] Read in function names for filtering from a text file.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: test/tools/llvm-cov/Inputs/name_whitelist.cpp:18
+    return 1;
+}
----------------
Just a reminder: please make sure that name_whitelist.covmapping is derived from an object built with `-mllvm -enable-name-compression=false`. I've been bitten by that before :) (not all the bots have zlib installed).


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:656
+    // Read in -name-whitelist files.
+    for (const auto &NameFile : NameFilterFiles) {
+      auto BufOrError = MemoryBuffer::getFile(NameFile);
----------------
In the future, we might benefit from the flexibility offered by llvm::SpecialCaseList. Could you use that to parse the whitelist?


https://reviews.llvm.org/D37111