[PATCH] D37123: [dwarfdump] Pretty print location expressions and location lists

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Thanks a lot for picking this up!



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:86
+    uint32_t getEndOffset() { return EndOffset; }
+    bool Extract(DataExtractor Data, const DWARFUnit *U, uint32_t Offset);
+    bool isError() { return Error; }
----------------
`extract`


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:88
+    bool isError() { return Error; }
+    bool Print(raw_ostream &OS, const DWARFExpression *U, bool isEH);
+  };
----------------
`print`


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:116
+
+    // Comparison operators areprovided out of line.
+    friend bool operator==(const iterator&, const iterator&);
----------------
`are provided`


================
Comment at: llvm/include/llvm/DebugInfo/DWARFExpression.h:80
+    uint32_t getEndOffset() { return EndOffset; }
+    bool Extract(DataExtractor Data, const DWARFUnit *U, uint32_t Offset);
+    bool isError() { return Error; }
----------------
`extract`


================
Comment at: llvm/include/llvm/DebugInfo/DWARFExpression.h:82
+    bool isError() { return Error; }
+    bool Print(raw_ostream &OS, const DWARFExpression *U, bool isEH);
+  };
----------------
`print`


https://reviews.llvm.org/D37123